[
http://jira.magnolia.info/browse/MAGNOLIA-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831#action_17831
]
Wolfgang Habicht commented on MAGNOLIA-2343:
--------------------------------------------
The change from Resource.getSelector() to request.getParameter("selector") does
not seem to be problematic for me.
But for me it is a step in the direction of complete removal of selectors and
that makes me worring a bit.
You wrote, you would like to streamline the code.
Between a selector and an URL parameter is a slight semantic difference: the
selector is a part of the URL (i.e. www.somehost.com/hello/world.large.html for
a large-font version of world.html) whereas a parameter is some additional
"information" (i.e. blog.html?elements=5 for showing the last 5 blog entries).
In my opinion using a VirtualURIMapping to convert selectors to URL-parameters
is - from a developer using Magnolia point of view - more complicate (it's not
just the actual call, also the needed VirtualURIMapping and to know what's
happening) and less intuitive. Keeping the actual selector handling also
reduces the risk, that some other change breaks the selector functionality. If
you allow at some point of time to have dots in node-names, selectors will no
longer work. As EE-customer we need to know in advance if we can relay on this
feature or not.
To bring it to the point:
- if you leave the working selector-code as is, selectors are still supported.
- if you mark Resource.getSelector() as deprecated, I must regard selectors as
whole as deprecated and possibly soon to be no longer supported.
> Selectors can be deprecated, virtual uri mappings can do a better job
> ---------------------------------------------------------------------
>
> Key: MAGNOLIA-2343
> URL: http://jira.magnolia.info/browse/MAGNOLIA-2343
> Project: Magnolia
> Issue Type: Task
> Components: core, templating
> Reporter: Gregory Joseph
> Assignee: Gregory Joseph
> Fix For: 3.6.2
>
> Attachments: Picture 1.png
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.magnolia.info/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
----------------------------------------------------------------
for list details see
http://documentation.magnolia.info/
----------------------------------------------------------------
