I notice what seem to be two weird code/typos in XML_Client.pm
parse_lookup_response subroutine. Maybe one of the developers
can answer my questions.
> sub parse_lookup_response {
>
> my ($hash,$key,$value,$item);
> my ($response);
>
> my $data = shift;
>
> $hash = $data;
Given the above, isn't the next block of 3 lines redundant?
> $hash->{response_code} = $data->{response_code};
> $hash->{response_text} = $data->{response_text};
> $hash->{is_success} = $data->{is_success};
>
> # what data conversions will be required to support
> # legacy client
>
In the next block, is it "response_code" or "_response_code" ?
If it's the latter, does that affect the first block?
> if ($hash->{response_code} == 210) {
> $hash->{status} = 'available';
> } elsif ($hash->{_response_code} == 211) {
> $hash->{status} = 'taken';
> } else {
> $hash->{status} = 'invalid';
> }
>
> return $hash;
> }
__________________________________________________________________
Colin Viebrock easyDNS Technologies
Co-Founder control your domain
http://www.easyDNS.com
