On 11/1/2012 7:09 PM, Iskren Chernev wrote:
I was reading mozilla's code related to WebRTC and I have some questions about 
using WebRTC in a different project:
* media/webrtc/signaling includes the "missing" PeerConnection implementation 
from webrtc/trunk. It seems like you (mozilla) implemented it -- the files have a MPL 
licence at the top, but the gyp file is from chromium? Do you intend to merge this 
upstream to WebRTC, because the current peerconnection webrtc includes libjingle and talk 
libraries from google as deps? Same question applies for media/mtransport, which 
(according to the comments inside) is intended for use only in webrtc context.

There's a benefit seen to have at least two separate implementations of a feature. We are relying on the core non-third-party code from webrtc.org (it would take too much time to reimplement all that. Signaling and transport in particular seemed ideal cases where alternative implementations would help avoid bugs getting baked in (often if everyone uses the same code, no one notices a bug because they all have it).

* media/webrtc/webrtc_update.sh fetches WebRTC repo, but the code that ends up 
in webrtc_update folder (the code that you're supposed to use as the new 
version?) has much more third_party code than the existing webrtc code in 
mozilla's repo (like libjingle for example).

There are more manual steps after this, because we found the automated script merged too much version-control history into the main repository, causing hg to be slow and large(r). We've been hand-merging to mozilla-central after the script runs, but will be revising the update procedure to try to re-automate it as much as possible.

--
Randell Jesup
Mozilla Corp; WebRTC module owner
_______________________________________________
dev-media mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-media

Reply via email to