It's been a week since we started the 'dev' branch on the mozilla/webvtt github repo. Thanks to those of you who've been answering my questions there.
I'd like to propose a workflow for pull requests. In particular, that anything merged into the dev branch must be approved by someone else. Code review helps catch errors, improves the quality of the code, distributes knowledge of the codebase and what people are working on. It is also an important part of the Mozilla process, so now's a good time to start. So, if you open a pull request against the dev branch, please @mention or assign someone you want to look at it. Usually that's someone who's done work in that part of the code, or whose opinion you're interested it. If you see a pull request, especially if it's in your area or you've been mentioned, read it and respond. In responding try to be clear which of these three options apply: - The pull request needs work. Say what the submitter needs to do to for you to be ok with it going in. - The pull request looks good, passes travis, and should be merged. On github the easiest way to say so is to click the 'Merge pull request' button. - The changes are an irredeemably bad idea. Say why and click 'Close'. Or, if it's your pull request, respond to any review comments. You can argue, you can fix, you can ask for clarification, but make sure you're clear what you need to do as the next step. So, yes, this means you can land stuff! Just don't merge your own pull requests without reviewer approval, "r+" or "LGTM" as they say at Mozilla or Google. I'd like to reserve merges to the 'master' branch for Chris and myself for now, but 'dev' is about getting the code improved and everyone can participate in that. Hopefully this will help us move quickly on improving the parser; I'd really like to get to the point where it's passing most of the tests asap. -r _______________________________________________ dev-media mailing list [email protected] https://lists.mozilla.org/listinfo/dev-media
