On 7/16/2014 4:49 PM, Randell Jesup wrote:
On 7/16/2014 3:33 PM, Benjamin Smedberg wrote:
To round out the loop on this: I filed additional breakdown bugs on
the crash reporting stuff. See
https://bugzilla.mozilla.org/showdependencytree.cgi?id=1009760&hide_resolved=1
I have taken bug 1039575/bug 1039577/bug 1039579 in order to get a
crash dump ID to GMPParent::ActorDestroy and properly annotate the
crash. This turned out to be harder than I expected because GMPParent
isn't a main-thread object and various crashreporter bits were making
thread assumptions. Those patches are now up in Ted's review queue.
I would like the webrtc team to take care of bug 1038961. I really
don't know the object lifetime/hierarchy for all of the webrtc code.
I see that it's currently assigned to Jesup.
I'm working on this today. To avoid lots of mods to upstream code,
I'll plan to call a static function exposed at the "other end" of the
webrtc.org code stack.
The other part is figuring out *when* to fire the plugin-failed
event. Do we have heuristics for detecting crashed or hung plugins I
can leverage?
My patch in bug 1039575 has a comment at precisely the point in
GMPParent::ActorDestroy where you need to pick up the crash.
--BDS
_______________________________________________
dev-media mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-media
