On 27 Aug 2014, at 13:57, Benjamin Smedberg <[email protected]> wrote:
> On 8/27/14, 7:35 AM, Georg Fritzsche wrote: >> On 27 Aug 2014, at 13:22, Benjamin Smedberg <[email protected]> wrote: >> >>> On 8/26/14, 10:25 PM, Chris Pearce wrote: >>>> With the landing of Bug 1045209, starting today in Firefox Nightly builds >>>> the disk layout of GMPs changed to accomodate multiple versions of a GMP >>>> being resident on disk. The consequence of that is that the usage of >>>> MOZ_GMP_PATH also changed. You are now must have a version subdirectory of >>>> your "gmp-*" directory, and put your .dll/.dylib/.so and ..info files in >>>> there. >>>> >>>> i.e. previously you could have: >>>> >>>> MOZ_GMP_PATH=/home/username/src/gmp-foobar/ >>>> >>>> ... and now you'll need: >>>> >>>> MOZ_GMP_PATH=/home/username/src/gmp-foobar/some_arbitrary_version_string/ >>>> >>>> What you call the version subdir is completely arbitrary for the purposes >>>> of using MOZ_GMP_PATH. >>> Was this intentional? This seems like an unfortunate side-effect of the >>> OpenH264-specific versioning which shouldn't have affected the GMP service >>> at all. >> This is a side-effect of how both GMPParent & GMPChild currently depend on >> the path/dir structure, i filed bug 1053727 on that earlier. > I think I still don't understand. Why did GMPParent/GMPChild change at all? > > <profile>/openh264/1.0/gmp-openh264/libopenh264.so > > The GMP service/parent/child just knows about > "<profile>/openh264/1.0/gmp-openh264" and doesn't need to know or care about > the versioning system that the install/update system uses. Both GMPParent & GMPChild look up the plugin id from the path: http://hg.mozilla.org/mozilla-central/annotate/0753f7b93ab7/content/media/gmp/GMPParent.cpp#l96 http://hg.mozilla.org/mozilla-central/annotate/0753f7b93ab7/content/media/gmp/GMPChild.cpp#l71 At least GMPChild needs it to pick up the library without scanning, that’s why i suggested to pass the id in from one code location - ideally remembered at registration time? Georg _______________________________________________ dev-media mailing list [email protected] https://lists.mozilla.org/listinfo/dev-media
