On 2013-01-03 1:28 PM, Benjamin Smedberg wrote:
On 1/3/13 1:23 PM, Boris Zbarsky wrote:
On 1/3/13 1:08 PM, Benjamin Smedberg wrote:
Do we know why this was happening? The log module specifies "nsDebug",
and it should only be written to the log if PR_LOG_MODULES includes
"nsDebug".
It's because InitLog in nsDebugImpl does this:
gDebugLog = PR_NewLogModule("nsDebug");
gDebugLog->level = PR_LOG_DEBUG;
and the second line force-enables gDebugLog at the PR_LOG_DEBUG level
no matter what NSPR_LOG_MODULES is set to, as long as it's set,
effectively.
Ah! I fully support removing that line so that nsDebug obeys the normal
rules of NSPR_LOG_MODULES. Count that as r+ to land if you like, and
that should be enough wallpaper to avoid the other patch for now.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8755061452d9
Cheers,
Ehsan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
