On Sat, Jan 18, 2014 at 2:03 PM, Ms2ger <ms2...@gmail.com> wrote: > On 01/18/2014 08:51 PM, Matthew N. wrote: > >> Hello, >> >> What does it mean to be a "Preferred Reviewer" (previously called a >> "peer") in a Toolkit sub-module[1] and not be on the list of Toolkit >> Peers[2]? The Toolkit Code Review page[3] doesn't seem to cover this case. >> >> Specifically: >> 1) Can a "Preferred Reviewer" review code in the related submodule >> without oversight from the sub-module owner? >> 2) Is a sub-module "Preferred Reviewer" considered a "Toolkit reviewer" >> for the purposes of [3]? >> > > In general, all reviews should be done by peers, so people who are not > peers should not be listed as preferred reviewers. > > HTH > Ms2ger > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform >
Historically we have given great deference to module owners who choose to delegate reviews to people who are not listed as peers, especially of patches written by the owner and listed peers. There are many reasons to do this, including working to grow new reviewers, choosing someone who understands a particularly specialized piece of code (potentially better than the owner), or load-balancing review requests by assigning reviews that need less scrutiny to people who are familiar with but not experts on the code in question. I don't think it's at all correct to say that all reviews should be done by peers. - Kyle PS. Don't you do a fair number of reviews in content/ and dom/? :P _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
