Another rather nice purpose for the s-r flag, in my experience, is exposed during onboarding of fresh, remote, engineers (like I was ~1 year ago): it allowed me to get acquainted with the review cycle while working on Good Next Bugs(tm) that touched intricate parts of the codebase, like DocShell, and the knowledgeable colleagues behind them. Also the social part of that process, I mean.
Being remote makes one (me) rely much more on the process facilitated by the tools in use and there are people behind them. And history... lots of that. In other words, this particular part of the process, s-r, made me connect with people that I respect and now know a bit better. Whether the s-r flag is meant for this purpose or not is debatable, but this is just what I experienced in practice. Do with this info as you please ;) Cheers, Mike. On 26 Apr 2014, at 04:34, Boris Zbarsky <bzbar...@mit.edu> wrote: > On 4/25/14, 10:06 PM, Doug Turner wrote: >> I tend to think that super review is a dumb idea. > > It's a hack around people doing bad reviews is what it is. > > There are certainly patches that are landing without official sr but that do > the moral equivalent of what sr is supposed to ensure: running the API design > by someone other than the reviewer whose judgment the reviewer trusts (via > feedback or needinfo or whatnot). > > As long as all our reviewers are competent enough to know when to do this > (aka "know what you don't know") we don't need an official sr requirement. > In practice we seem to have been dealing without official sr, as you note. > > Of course if all our reviewers knew what they don't know we also wouldn't > need a commit hook on dom/webidl to catch patches there landing without DOM > peer review.... ;) > > -Boris > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform