On Monday 2014-12-22 17:54 -0500, Ehsan Akhgari wrote:
> On 2014-12-22 4:56 PM, L. David Baron wrote:
> >I think removing implicit conversions to T* will make a lot of code
> >in the tree uglier (".get()" everywhere). That might, in turn,
> >encourage people to do worse things to avoid having to write .get()
> >everywhere; it's worth thinking about what those things will be.
>
> Do you have any examples of those bad things? (FWIW I'm all for
> making bad things impossible.)* using raw pointers instead of smart pointers * making functions take nsRefPtr<T>& instead of T*, leading to unnecessary risk of mutation of the caller's pointer and extra indirection * ... and perhaps the same for getters * using C-style casts (or reinterpret_cast) to make things compile -David -- 𝄞 L. David Baron http://dbaron.org/ 𝄂 𝄢 Mozilla https://www.mozilla.org/ 𝄂 Before I built a wall I'd ask to know What I was walling in or walling out, And to whom I was like to give offense. - Robert Frost, Mending Wall (1914)
signature.asc
Description: Digital signature
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
