I have been faced a few times with reviews that languish several weeks/months, despite direct communication with the reviewer, so indeed, I definitely agree that we need to improve the situation.
I suspect that, in most cases, the lack of reviews were due to succession of unexpected, high-priority, work being pushed onto my reviewers, who found themselves suddenly in high-stress, "drop everything else" scenarios. I personally dislike escalating review requests. A lot. So here are a few random ideas of things we could possibly improve: * bootlenecks - increase the number of reviewers on all bottlenecks (even if this means that we need to initially increase the number of super-reviews, too); * management - encourage developers to say "no", either to high-priority features or to review requests, when they can't cope – this includes emulating bz' "I do not accept review requests at the moment"; - encourage managers to hear such negative replies; - when a high-priority feature interrupts the usual workflow, decide with the manager of the relative priorities of this feature wrt ongoing reviews; * tooling - write a dashboard that lets managers find out just exactly how busy developers are/the entire team is, and how long review queues are, to be able to adjust workload (e.g. http://yoric.github.io/bugzilla-dashboard/#username=dtel...@mozilla.com ) Cheers, David On 18/03/15 16:39, Gabor Krizsanits wrote: > I think I'm not the only one experienced issues with reviews from one side > or the other. > I'm wondering if we could do some improvements here for everyone's sake. > > Here are the issues the way I see it: > * some parts of the code need more peers > - we should identify the areas > - we should select candidates > - there should be a clear path to become a peer > (reading up code/spec, asking for sr's first and starting with easier > ones, etc) > * reviews are not part of our goal system > - it makes no sense to work on something if for the > reviewer will likely take several weeks or even months > to get to the review (for various but foreseeable reasons) > - people who are flooded with reviews cannot focus on their > actual goals they signed up for, or have to block people by > not doing reviews > > Maybe I'm just not well informed, and all these issues are already being > taken care of... But if not, I would like to hear what others think. > > - Gabor > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > -- David Rajchenbach-Teller, PhD Performance Team, Mozilla
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
