On 2015-09-25 12:01 PM, Justin Dolske wrote:
On 9/25/15 7:06 AM, Robert O'Callahan wrote:
[...]I'm not quite sure
what it would take to get those build failures to appear in MozReview
but
it should be possible.
The tricky bit is to determine which failures were introduced by the
patch,
and just display those, and display them in the context of the patch in
some way that makes sense.
Yeah, I think this needs a solution to be effective.
*begin thousand yard stare*
In a previous life at Sun, all new code was required to pass lint and
cstyle checks, and it was strictly enforced. Of course, tons of existing
code did not pass, and so it became an enormous PITA to diff piles of
output.
At Mozilla, it seems like previous discussions on this kind of thing
(style and warnings come to mind) have dealt with this at a
file/directory/module level... Someone fixes up a thing completely, adds
it to a whitelist, and then it's a simple pass/fail. Could that work
here too?
Yes, that is another option for checks that tons of existing code don't
pass.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
