> On Jan 21, 2016, at 21:46, Mike Hommey <m...@glandium.org> wrote: > >> On Thu, Jan 21, 2016 at 06:35:08PM -0800, Gregory Szorc wrote: >> If you have level 3 source code access (can push to central, inbound, >> fx-team) and have pushed to MozReview via SSH, as of a few weeks ago you >> can now land commits from the "Automation" drop down menu on MozReview. >> (Before only the review request author could trigger autoland.) >> >> This means that anyone [with permissions] can land commits with a few mouse >> clicks! It will even rewrite commit messages with "r=" annotations with the >> review state in MozReview. So if someone does a drive-by review, you don't >> have to update the commit message to reflect that reviewer. Neato! > > Just to be sure, this only happens if the drive-by does "ship-it", > right?
Correct. And there might also be LDAP group permissions checks involved as well (for hysterical raisins that we're revisiting). At some point we may want to hook up a more formal "reviewers database" to identify "appropriate" reviewers. Let's try not get into that bag of worms just yet... _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
