Given GSL's pedigree, I was assuming that we'd bring it in-tree and switch out MFBT facilities with the corresponding GSL things as they became available.
One of the main roles of MFBT is to provide polyfills for features standardized in C++ that we can't use yet for toolchain reasons (remember MOZ_OVERRIDE?); MFBT features get removed as we replace them with the corresponding std thing. Why would Range vs. GSL span be any different? On Fri, Jul 15, 2016 at 3:44 AM, Henri Sivonen <hsivo...@hsivonen.fi> wrote: > On Thu, Mar 24, 2016 at 6:01 PM, Jeff Muizelaar <jmuizel...@mozilla.com> > wrote: > > On Wed, Jan 6, 2016 at 7:15 AM, Henri Sivonen <hsivo...@hsivonen.fi> > wrote: > >> On Thu, Oct 1, 2015 at 9:58 PM, Jonathan Watt <jw...@jwatt.org> wrote: > >>> For those who are interested in this, there's a bug to consider > integrating > >>> the Guidelines Support Library (GSL) into the tree: > >>> > >>> https://bugzilla.mozilla.org/show_bug.cgi?id=1208262 > >> > >> This bug appears to have stalled. > >> > >> What should my expectations be regarding getting an equivalent of (at > >> least single-dimensional) GSL span<T> (formerly array_view<T>; > >> conceptually Rust's slice) into MFBT? > > > > Something like this already exits: mfbt/Range.h > > And we also have > https://dxr.mozilla.org/mozilla-central/source/gfx/src/ArrayView.h > whose comments say to prefer Range. > > ArrayView as well as GSL span use pointer and length while Range uses > pointer and pointer past end. > > Are we happy enough with Range to the point where Range should be > promoted in the codebase where the Core Guidelines would recommend > span? > > (What to call it is, of course, a total bikeshed, but when the Core > Guidelines are happening near the C++ standardization source of > authority, it seems rather NIH-y to call it something other than > "span" even if there are still compiler compat reasons [are there?] > not to use Microsoft's span.h outright.) > > -- > Henri Sivonen > hsivo...@hsivonen.fi > https://hsivonen.fi/ > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
