On Mon, Aug 15, 2016 at 11:59 AM, Bobby Holley <bobbyhol...@gmail.com> wrote:
> On Mon, Aug 15, 2016 at 11:53 AM, Henri Sivonen <hsivo...@hsivonen.fi> > wrote: > >> What I'm asking is: >> >> When I take encoding_rs_cpp.h and adapt it to XPCOM/MFBT types for use >> in Gecko, should this be >> Encoding::for_label(const nsACString& label) // change only types that >> need changing >> or >> Encoding::ForLabel(const nsACString& aLabel) // change naming style, too >> ? >> > > > The latter, IMO. > I would agree. The disadvantage is that people familiar with the Rust API would now have to study the C++ API separately, because they're no longer trivially related. But you've already adapted the argument types to Gecko, and presumably made other sorts of changes to provide an idiomatic C++ API. That's a good choice, in my opinion, but it means you've already given up the prospect of taking familiarity with the Rust API and applying it immediately to use the C++ API. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
