On Sat, May 20, 2017 at 4:55 AM, Kris Maglione <kmagli...@mozilla.com> wrote: > Can we make some effort to get clean warnings output at the end of standard > builds? A huge chunk of the warnings come from NSS and NSPR, and should be > easily fixable.
Hmm, these are all -Wsign-compare issues bar one, which is fixed upstream. We have an open bug tracking the warnings (https://bugzilla.mozilla.org/show_bug.cgi?id=1307958 and specifically https://bugzilla.mozilla.org/show_bug.cgi?id=1212199 for NSS). NSS is built with -Werror separately, but disables errors on -Wsign-compare. Disabling those warnings for a Firefox build of NSS wouldn't be so bad now that we share gyp config. Based on a recent build, that's 139 messages (add 36 if you want to add nspr). I've spent a little time looking into the real issues. Fixing requires some care, since it touches ABI compat in many places. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
