On Wed, Oct 18, 2017, at 07:51 AM, Mark Banner wrote: > Looping in firefox-dev as well, as I thin this is an important > discussion. > > On 18/10/2017 09:28, David Teller wrote: > > Hi everyone, > > > > Yesterday, Nightly was broken on Linux and MacOS because of a typo in > > JS code [1]. If I understand correctly, this triggered the usual > > "undefined is not a function", which was > > > > 1/ uncaught during testing, as these things often are; > Part of the reason it was uncaught, is that there's no automated test > coverage for that bit of code. It is a migration from one version to the > other, but unless there is an explicit test (and I don't see one) that > line won't be hit.
Given this bit, would any of the suggestions in this thread actually help? If we're not exercising this code in automated tests, would "fail tests on uncaught exceptions" make any difference? I'm generally in favor of being stricter about errors in our test suites etc, but I'm curious about whether we would actually have solved the problem in question. -Ted _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
