On 2018-01-04 10:00 AM, Nathan Froyd wrote:
…
2) How would one shoehorn this into *DL? The options that come to mind are:
- Separate methods for every observer topic, which sounds terrible
from a code duplication perspective. Though maybe this would be nice
for JS clients, so we could say things like:
Services.obs.notifyXPCOMShutdown(...)
which would save on some xpconnect traffic and representing a
large-ish enum in JS?
- WebIDL enums (I think), which would carry a large space penalty and
make everything that wants to use the observer service depend on code
from dom/, which seems undesirable.
- IDL enums, which aren't reflected into JS, so we'd need some custom
work there.
As Ben said, XPIDL const's on an interface seem like a missing option
that would work with JS. Random example:
https://dxr.mozilla.org/mozilla-central/search?q=RECOVER_SESSION&redirect=false
- IPDL doesn't even have the concept of definable enums, and wouldn't
reflect things into JS, so we'd need even more work there. (Some of
this may be desirable; we talked about extending IPDL bits into JS in
Austin, and kmaglione felt this was reasonable, so...)
The first and third don't sound *too* bad, but I don't think that
writing a one-off code generator would be strictly worse...
MattN
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
