This is great. Thanks! -Ekr
On Tue, Oct 2, 2018 at 7:04 AM Kartikaya Gupta <[email protected]> wrote: > Neat! I took a quick peek at your addon source and the stuff it's > relying on seems ok for now. At least, it's not anything we plan to > change anytime soon. If there are changes to searchfox that would make > your life easier in terms of expanding your addon, let me know and we > can discuss possibilities. > > Cheers, > kats > On Tue, Oct 2, 2018 at 9:03 AM Marco Castelluccio > <[email protected]> wrote: > > > > I've built an (experimental) WebExtension to integrate some of the > > Searchfox features into Phabricator. > > I find it very useful to be able to search code while reviewing, but I > > have to resort to opening a new > > Searchfox tab and looking for the code that is being modified. This > > extension makes my workflow much > > more pleasant. > > > > You can find it at > > https://addons.mozilla.org/addon/searchfox-phabricator/ (the source code > > is at > > https://github.com/marco-c/mozsearch-phabricator-addon). > > > > Currently, the extension does: > > 1) Highlight keywords when you hover them, highlighting them both in the > > pre-patch and in the post-patch view; > > 2) When you press on a keyword, it offers options to search for the > > definition, callers, and so on (the results are opened on Searchfox in a > > new tab). > > > > I'm planning to add support for sticky highlighting and blame > > information (when hovering on the line number on the left side). > > > > - Marco. > > > > P.S.: The extension relies on parsing pages from Searchfox and from > > Phabricator, so the maintenance might not be so easy. If there's enough > > interest, I might keep maintaining it or talk with someone to make > > Searchfox data accessible in an easier way. > > _______________________________________________ > > dev-platform mailing list > > [email protected] > > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ > dev-platform mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
