On 6/11/19 7:49 AM, Kartikaya Gupta wrote:
IIRC another difference between prefs in all.js and gfxPrefs was that if a
pref was not listed in all.js, you couldn't use it in the
{test-,ref-,}pref(...) annotations in reftest.list files.

That restriction is due to the code at https://searchfox.org/mozilla-central/rev/0da35261b6789eec65476dbdd4913df6e235af6d/layout/tools/reftest/reftest.jsm#675-699 refusing to set the new value if it can't get the old (to-be-restored-later) value. From that point of view, StaticPrefs and all.js are equivalent: both provide an existing value to work with.

That said, we could probably improve this code to restore no-value-set-before prefs via clearUserPref so it would not have this restriction at all.

-Boris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to