On Mon, Oct 14, 2019 at 8:05 AM Gerald Squelart <gsquel...@mozilla.com> wrote:
> A quick&dirty searchfox shows a few hundred by-value unique pointer's, we > may want to look into these. > Though I guess it's a trade-off between the expressiveness of by-value > ("I'm stealing your value for sure") vs the more efficient but less obvious > by-rref ("Maybe I'll take your value"). > For what it's worth, this is what our documentation recommends [0]: "To unconditionally transfer ownership of a UniquePtr into a method, use a |UniquePtr| argument. To conditionally transfer ownership of a resource into a method, should the method want it, use a |UniquePtr&&| argument." I've definitely passed UniquePtr by value a number of times based on this comment. Jan [0] https://searchfox.org/mozilla-central/rev/6866d3a650c826f1cabd123663e84b95ee743701/mfbt/UniquePtr.h#179-186 > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform