On 10/16/19 10:11 AM, Simon Giesecke wrote:
I am wondering if the following is supposed to be safe:
I would think so, yes. That said, using string types as return values is not that common (using an outparam is the normal way they are used), and so may be under-tested.
On the treeherder builds, this seems to work fine. But reportedly, this crashes on a release build on Mac OS X 10.13 on startup. Static analysis does not catch a problem here. Assigning the result of MakeColumnPairSelectionList to an intermediate variable fixes the issue there (https://phabricator.services.mozilla.com/D49422).
It's worth trying to pin down what's going on there on Mac (e.g. by looking at the generated assembly) to see whether it's our bug, a compiler bug, or something else...
-Boris _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
