Thanks for the feedback Emilio! The uplift changes are a work in progress, this kind of feedback is welcome. Please file bugs for your three suggestions in the Lando component (I'm not sure if the form related one is viable, but let's get it on file).
Regarding the API key part; we already have plans to rework Lando's authentication system, which should make this pain point go away. Note an alternative workflow is to request the uplift from the command line, via `moz-phab uplift` while the original changes are checked out. This may or may not be easier. -glob -- glob ∙ moz://a Senior Engineering Manager ∙ Engineering Workflow & Release Management > On 30 Oct 2023, at 9:43 pm, Emilio Cobos Álvarez <[email protected]> wrote: > > [Sending from my MoCo email, sorry Connor for the double email] > > So this is a lot more clicks needed to request an uplift for a simple > patch/stack that doesn't require manual rebasing (which are the majority). > > Normally, bugbot needinfos me on a bug that affects beta but I've fixed on > Nightly. Once I get to that needinfo, I need to: > > * Click the attachment details of the relevant patch. > * Change the flag and fill the form. > * Click submit. This will also clear the needinfo, quite conveniently. > > With this new workflow I need to do a ton more clicks: > > * Click on the relevant patch to go to phab. > * Go to lando. Note that you need to know what you're doing because the lando > link on a closed phabricator revision looks disabled. > * Introduce the API key (which requires a few more clicks). Also note that if > you're missing the API key the button is completely disabled and nothing > tells you "you can request uplift if you introduce the API key". > * Request the uplift in Lando. > * Remember to fill the uplift request form manually in phabricator. Otherwise > the relman group isn't tagged as a reviewer in the revision. > * Go back to the bug and clear the needinfo. > > That adds quite a lot of friction. Is there some plan to improve that? Some > things that I can think are: > > * Including the link to lando (and to the new workflow) in the bugbot comment. > * Including the uplift request form at the point you're going to request the > uplift. > * Automatically clear the needinfo once the uplift request is submitted. > > Thanks, > -- Emilio > > On 10/27/23 17:35, Connor Sheehan wrote: >> Hello Firefox developers, >> tl;dr: Uplift requests are moving from Bugzilla to Lando/Phabricator. Please >> create uplifts with `moz-phab uplift` or Lando and submit the uplift request >> form on Phabricator. The process is outlined here: >> https://wiki.mozilla.org/index.php?title=Release_Management/ >> Requesting_an_Uplift <https://wiki.mozilla.org/index.php? >> title=Release_Management/Requesting_an_Uplift> >> Here is an example of a completed request: https:// >> phabricator.services.mozilla.com/D176307 <https:// >> phabricator.services.mozilla.com/D176307> >> --- >> We are making some changes to the Firefox uplift process, tracked in >> https://bugzilla.mozilla.org/show_bug.cgi?id=uplift-automation <https:// >> bugzilla.mozilla.org/show_bug.cgi?id=uplift-automation>. For anyone who >> hasn't submitted an uplift before, uplifts are requests made by Firefox >> developers to Release managers, requesting a patch or set of patches be >> pushed directly to our release repositories. This bypasses the usual 8 to 12 >> week release cycle and is useful for security patches, infrastructure >> patches and many other use cases. >> We are moving the process of requesting and landing uplifts from Bugzilla to >> Phabricator and Lando. You can now submit patches to Phabricator for uplift >> using Lando (which does not require a local checkout with the patch >> applied), or by using the `moz-phab uplift` command. The uplift request >> questionnaire will be submitted on Phabricator, using the same menu as >> "Accept Revision" and other review actions. Lando will enforce a review from >> the `release-managers` review group and enforce the uplift request >> questionnaire is submitted on at least one patch in the stack. If patches >> fail to land, it is now the developer's responsibility to resolve merging >> issues and re-land patches. >> As the changes made by each uplift request are tracked in new Phabricator >> revisions, the normal Phabricator processes and automation are available. >> For example, if a patch requires significant changes to cleanly apply to the >> target repository, you'll have the option to ask for code review prior to >> landing. >> This new process will reduce the overhead time for handling uplift requests >> placed on the Release management team and avoiding the need to run local VCS >> operations. It will also decrease the attack surface by revoking some >> special push privileges. We also expect this change to enable faster >> requesting and landing of uplift requests, as the uplift process is more >> closely aligned with the regular process for submitting and landing patches. >> Thanks to the Release Management team and all the engineers who took part in >> the pilot. >> Cheers, >> Connor >> -- >> You received this message because you are subscribed to the Google Groups >> "[email protected]" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <mailto:dev- >> [email protected]>. >> To view this discussion on the web visit https://groups.google.com/a/ >> mozilla.org/d/msgid/dev-platform/bfa5c189-40f0-429b- >> ad50-72b5b9990f37n%40mozilla.org <https://groups.google.com/a/ >> mozilla.org/d/msgid/dev-platform/bfa5c189-40f0-429b- >> ad50-72b5b9990f37n%40mozilla.org?utm_medium=email&utm_source=footer>. > > -- > You received this message because you are subscribed to the Google Groups > "[email protected]" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/2b60c2fe-30e5-43ae-971a-a395d7abe166%40mozilla.com. -- You received this message because you are subscribed to the Google Groups "[email protected]" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/a/mozilla.org/d/msgid/dev-platform/5BC876FE-AEEA-40DF-AEC0-120BF5144E86%40mozilla.com.
