Daniel Veditz wrote: > On 4/5/2013 5:26 PM, jeremy.ral...@gmx.ch wrote: > > a comment in nsIContentPolicy.idl says > > > > /* When adding new content types, [...] > > Note that nsIContentPolicy is a public contract and that lots of > add-ons use it -- you can never rebuild enough to know you haven't > broken anything. If Gecko starts doing some new behavior and we add > a type it's less likely to break these other uses, but if you > create a new type to cover part of an existing category you're more > likely to create problems.
Yes, we should avoid adding new types that are subsets of anything except TYPE_OTHER. IIRC, I am the one that wrote the "When adding new content types" comment and I enumerated the places that need to be updated *that I was aware of at the time*. I wrote that comment because I was surprised at all the places that need to be updated, but I did so from a position of extreme ignorance as I was very new to nsIContentPolicy at that time. I am not super confident in how comprehensive that list of places is, unfortunately. If you find a place that needs to be updated that I ommitted, please file a bug so that we can amend the documentation. Cheers, Brian _______________________________________________ dev-security mailing list dev-security@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-security
