I tried to use Reviewable in some pull request. I'll write some feedback of my feeling:
pros: - The mascot icon is so cute (critic has no it!). It relaxes me when I open a pull request. :) - The comments showing up on Github is great! cons: - If a pull request has a multiple commits, Reviewable displays them as squashed into one commit. - This is very difficult point. There is no difference from Github's default diff view. - This will be great dis-advantage if we review a big pull request. Thanks! 2015-04-15 6:15 GMT+09:00 Lars Bergstrom <[email protected]>: > As was mentioned briefly in the meeting notes for this week > (https://github.com/servo/servo/wiki/Meeting-2015-04-13 > <https://github.com/servo/servo/wiki/Meeting-2015-04-13> ), we are trying a > new service, http://reviewable.io <http://reviewable.io/>, for performing our > reviews. This week, please make an effort to try out the tool for your > reviews by clicking on the large purple “review on reviewable” link in the PR > and let me know either via e-mail or IRC what you do and don’t like about it. > Comparisons to either Critic or the built-in GitHub review UI are welcome. > > I’m trying this out because: > - It handles rebases / force-pushes to PR branches automatically (easily our > #1 Critic failure point, especially for new contributors). > - The comments show up on GitHub & GitHub comments show up there, so there’s > no “two worlds” experience. > - I only need to feel guilty for begging jgraham to help with our Web > Platform Tests integration, and not both that AND our twice-weekly Critic > crises. > > Thanks, > - Lars > > _______________________________________________ > dev-servo mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-servo -- Tetsuharu OHZEKI _______________________________________________ dev-servo mailing list [email protected] https://lists.mozilla.org/listinfo/dev-servo
