On 3/7/18 6:04 AM, Imanol Fernández wrote:
We talked a bit about standalone NDKs when we worked on adding support for
new android CPU architectures here:

The benefit of using a standalone NDK is that we have to configure less CXX
flags in Servo. But the main concerns are that is another step and failure
point for people building for Android. Also we have to create different
standalone NDKs for each architecture: armv7, arm64, x86, etc which can
increase build sizes and steps for the user.

IMO is better that we assume the CXX flags set up complexity and only make
the users to set up the PATH to the default android-ndk folder. At least
that's the usual way to compile android libraries. In fact, I had never
heard of standalone NDKs after a lot of time working & compiling libs for
Android until I worked on that Servo integration.

One way we could continue to assume the complexity is by creating the standalone NDK as part of the regular build. If the build system checks for a .android directory that contains an NDK for the desired target, it goes ahead and builds with the right settings. Otherwise, it checks for the presence of the ANDROID_NDK path and invokes the make_standalone_ndk.sh with the right arguments to create one in .android.

dev-servo mailing list

Reply via email to