[EMAIL PROTECTED] wrote: > I may have missed this, but do we have a dehydra script to look for > objects that are ref-counted, that contain what appear to be member > pointers to other ref-counted types, that are not users of the > NS_CYCLE_COLLECTION_*. We'd want this soon, in case something turns up > that's easy to fix for Gecko 1.9. Thanks,
This analysis doesn't sound hard, but you're going to end up with lots of false-positives: i.e. all the necko classes, which certainly have member-comptrs but can't be cycle-collected because they are multi-threaded objects. I don't think we are or should be trying to cycle-collect every XPCOM object that has strong refs (even just the single-thread ones)... doing so would require lots and lots of additional classes be cycle-collected: you'd have to add many services which already have application lifetime, so the cycle collector would only be a benefit in cleaning up shutdown cycles, if at all. Some examples that come immediately to mind: * observer service * prefservice * appstartup cc'ing dev.platform in --BDS _______________________________________________ Dev-static-analysis mailing list [email protected] https://lists.mozilla.org/listinfo/dev-static-analysis
