Hi Jean-Marc, It would be a lot easier if you could report all your issues directly on bugzilla (under webtools -> DXR). That's the only task list we are using for now.
Lionel Le 23/05/2012 14:30, Jean-Marc Desperrier a écrit : > Lionel Dricot a écrit : >> Le 22/05/2012 21:20, Jean-Marc Desperrier a écrit : >>> - the yellow bar is a bit annoying as it can't be dismissed >> >> For me, clicking anywhere on the yellow bar dismiss it. Is it not >> working for you or should we make that more discoverable by putting a >> close link on the right ? > > You're right, I didn't expect I could dismiss it by clicking anywhere. > > An hard to hit close link wouldn't be great, I think the best would be > a large "dismiss" button. > >>> - click on "SamplerStackFrameRAII" in line 144 >>> - in the pop-up click on "Declared at >>> tools/profiler/sps_sampler.h:147:3" >>> - loading >>> http://dxr.lanedo.com/mozilla-central/tools/profiler/None/mozilla-central/tools/profiler/sps_sampler.h.html#l147 >>> >>> which fails with a "Not Found" error. >> >> The link you've pasted looks wrong, indeed. But I cannot reproduce that >> on dxr.lanedo.com. It might have been fixed in the mean time. Could you >> try to reproduce ? > > I can't repro anymore this morning. But it's a bit annoying if you > have no idea why there was this result yesterday. > > Globally DXR does seem to work quite well, even if it feels a bit rough. > > I have a list of point which fell a bit annoying even if none is big > problem : > - the search when opening a pop-up feels a bit long. Given the kind of > interface that is used, you want this to be snappy and it's just not yet > - At least it would be help if the result was held in a local cache, > and reused the next time instead of searching again > > The pop-up hides the rest of the code, I think it pushes you to open > it, want to check the code below so decide to close it first, then > need to reopen it. > > - it should be easier to dismiss the pop-up. I feel clicking inside > the "Search for "xx"..." line should dismiss it. > - when the target of a link is within the last lines of the file, you > should still scroll it to the middle of the screen, showing a blank > space below it. > - the "Calls"/"Called by" lists are great, but it feels like the > "Called By" should be integrated more with the "References:" list. > > OK, here's what I'm thinking (taking the example of the push function at > http://dxr.lanedo.com/mozilla-central/tools/profiler/sps_sampler.h.html#l207) > : > void ProfileStack::push(const char *) > Definition at tools/profiler/sps_sampler.h:207:8 > Declared at tools/profiler/sps_sampler.h:207:8 > > References: > Called at tools/profiler/sps_sampler.h:261:10 > by: void * mozilla_sampler_call_enter(const char *) > > Calls: > Size_t mozilla::ArrayLength(T (&)[N]): > > - I think the "Definition/Declared lines" for the function listed > inside "Calls/Called by" should not be shown by default, only after > you click on the function line > - Taking the example of mStack at > http://dxr.lanedo.com/mozilla-central/tools/profiler/sps_sampler.h.html#l235 > If your are able to do the called by thing for function, it would be > great to do also this for variables (yes, always asking for more): > References: > Used at tools/profiler/sps_sampler.h:261:10 > by: void ProfileStack::push(const char *aName) > - the same goes for things like "struct ProfileStack" at > http://dxr.lanedo.com/mozilla-central/tools/profiler/sps_sampler.h.html?string=ProfileStack#l164. > There's a long list of references, it would be great to know inside > which function each reference is. > - When there's a list of reference like that, an usual cinematic will > be to click on one of them, access the code, and then click again on > the identifier to display the list and go to another reference. > It therefore would be *really* useful to load the result from a local > cache instead of searching again. Will help the server too. > _______________________________________________ > dev-static-analysis mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-static-analysis _______________________________________________ dev-static-analysis mailing list [email protected] https://lists.mozilla.org/listinfo/dev-static-analysis
