On 08/02/2012 11:36 PM, Benjamin Peterson wrote: > Couldn't you detect gdb in the test? Certainly --- the concern isn't that the test would always fail on OSX and Windows; it's not difficult to detect whether they're appropriate to run, and skip them if not.
The pretty-printers know about the details of the implementation; they break when the implementation changes, and need to be brought up to date. So I'm concerned that, from time to time, a developer on OSX/Windows will change the implementation; run tests locally (skipping the pretty-printer tests) and see that all is okay; and then push to try and see that the GDB pretty-printer tests are now failing because of their change. It seems unfair to expect people to fix tools they don't use. The burden of maintenance should be on the users of that tool. But if the general consensus is that I'm worrying too much about this, and that everyone on the JS team is expected to be fluent in all four platforms - or perhaps it just so happens that none of us avoid Linux - then we can just hook it all up. _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
