On 12/11/2012 12:11 PM, Terrence Cole wrote:
On 12/11/2012 11:40 AM, Brendan Eich wrote:
Terrence Cole wrote:
I'm also still working on getting the Shape changes landed: turns out
more of the paths through IonBuilder can GC than I thought.
Can't we just disable GC when in IonBuilder?
/be
The reason I made these so aggressively into UnrootedShape is that I
thought GC /was/ disabled in all of IonBuilder. Since then, I have
noticed that there is some sporadic use of Roots/Handles throughout the
file, so I expect that this is a long-standing problem.
I'm hoping Nicolas, David, or Brian can chime in here with a more
nuanced explanation of how IonBuilder should be interacting with the GC:
I'm not an expert in this area of code.
Most allocation happening in IonBuilder are temporary allocation, either for
internal Ion stuff or for type constraints. I guess only a few places such
as template objects creation would have to be protected.
--
Nicolas B. Pierron
_______________________________________________
dev-tech-js-engine-internals mailing list
dev-tech-js-engine-internals@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
