On Tue 17 Sep 2013 16:52, Andy Wingo <[email protected]> writes: > It is difficult to preserve compatibility in the builder interface, > while adding new variations on old syntax. Furthermore there is this > positional argument protocol, where the builder callback has to know > which arg maps to which named part. > > So my concrete question is, firstly, what do I do for yield* and ES6 > generators? Do I break the callbacks by adding a positional before the > location? Do I add an argument after the location? Do I diverge from > Esprima, and add a different AST node type with its own callback > signature?
My initial approach was to introduce a new AST node. But following this discussion, I will use the Esprima YieldExpression node. But that means breaking users of the builder interface that also use the location argument. There do not appear to be any of those in the test suite, and a try build is green, so that is my current plan. Andy _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
