On Tue, Apr 14, 2015 at 2:24 AM, Cameron Kaiser <ckai...@floodgap.com>
wrote:

> The Bataan death march towards a PowerPC Ion backend continues unabated
> (though IonPower does now run 50% of V8 with --ion-eager
> --ion-offthread-compile=off, which I consider a hardwon achievement).


Nice!


> If input is in volatile registers, wouldn't the restoreVolatile at line
> 3894 clobber it? Or am I misunderstanding this?


Yes, the restoreVolatile could restore |input| (or just its type or payload
register). The "masm.popValue(input)" immediately before that is a bit
confusing, but I think that's just to discard the stack space we used for
the call argument. |input| should be exactly the same Value we pushed on
the stack before the call, so restoreVolatile can safely clobber it with
the original values.

Hope this helps,

Jan
_______________________________________________
dev-tech-js-engine-internals mailing list
dev-tech-js-engine-internals@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals

Reply via email to