On Thu, Apr 28, 2016 at 9:36 PM, hv1989 <[email protected]> wrote: > > We do have this for IonMonkey in debug builds > - After every pass we call AssertBasicGraphCoherency, AssertGraphCoherency > or AssertExtendedGraphCoherency. > - For every LIR we assert that the result is in the expected type (wrt to TI > info) > > Both happen only in debug builds and make JS painfully slow. (Not an issue > in the shell) > Quite annoying in the browser. Maybe as a result less/no-one is running > debug builds anymore?
I doubt anyone is doing large amounts of browsing in debug builds. They are very slow :( > - Should we look at how to make browser not a pain in debug builds (will > make it harder to get the expected asserts)? Hoping that more people run it? > Or will people still not run debug builds. > - Should we look into running those asserts in release builds (on nightly) > on a not often 'random' bases? Making sure it doesn't hurt performance too > much? I suspect the random idea is more practical. > Another issue I want to raise is that we don't have any information about > EnterBaselineMethod increasing/decreasing over time. > Might help to have this static and see how it evolves over time. That way we > at least have an idea if we are improving/regressing ... > I have had patches were I would have expected a possible raise/decrease in > crashes. But since we have no information it is quite hard. > Having this metric (even over longer pushlog) would make it possible to > pinpoint possible patches and backout and see if that helps the stats. > (Not trivial to see, since we would have to see only nightly and de-bias > over the numer of users and hours used?) My experience with Nightly crash report analysis is that the numbers vary significantly from day to day. Typically the #1 topcrash for a particular Nightly will only happen ~10 times. So it seems hard to get this metric reliable, unfortunately. Nick _______________________________________________ dev-tech-js-engine-internals mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
