Surely the 80 column limit can be changed in Gecko? Does anyone have 80-column monitors still?
-David On Tue, May 10, 2016 at 11:25 PM, Jan de Mooij <jdemo...@mozilla.com> wrote: > On Wed, May 11, 2016 at 4:15 AM, Jason Orendorff <jorendo...@mozilla.com> > wrote: > > > I've said before that we won't do this without talking it over as a team. > > Well, team? What do you think? > > > > I'm also not a fan of Gecko's style but if it's better for the project we > should do it. The current situation is especially silly when it comes to > MFBT: some classes (like Vector or Maybe) still use 'our' style, and using > a Gecko-style class in SpiderMonkey code feels awkward. > > That said, two minor nits: > > (1) A lot of our code fits in 99 columns but not within 80 (even with 2 > space indent). We should make sure reformatting these long lines leaves us > with something reasonable. > > (2) C++11 range-based for loops work with 'begin' and 'end' methods, not > 'Begin' and 'End'. It's a bit unfortunate to move towards a style where we > need separate 'begin'/'end' aliases to get working for-loops. Most classes > don't need this, though, so it's probably not a big deal. > > Jan > > > > Personally I dislike the 2-space indent. But what matters to me here is > > eliminating a speed bump for both Gecko and SM hackers; and reducing > > pointless arguments on dev.platform. Whether or not I personally like the > > style is not even close to being on that list. > > > > -j > > _______________________________________________ > > dev-tech-js-engine-internals mailing list > > dev-tech-js-engine-internals@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals > > > _______________________________________________ > dev-tech-js-engine-internals mailing list > dev-tech-js-engine-internals@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals > _______________________________________________ dev-tech-js-engine-internals mailing list dev-tech-js-engine-internals@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
