I just went through and found a bunch of places where we were including windows.h directly. Which defines macros like min, max, GetProp, and CONST. I didn't think this really mattered much, but coincidentally I shortly thereafter encountered code that was doing contortions to work around it, like calling (std::min)(a, b) -- apparently, the initial parentheses are needed to avoid getting the macro version?

Anyway, it's weird and we shouldn't have to worry about making a local variable named max, so use jswin.h or you will face the humor of the trickster god of unified builds.


_______________________________________________
dev-tech-js-engine-internals mailing list
dev-tech-js-engine-internals@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals

Reply via email to