Hi all, The following scripts now run as part of the build instead of `make check` (assuming [0] sticks): * check_spidermonkey_style.py * check_macroassembler_style.py * check_js_opcode.py
(There's another script, check_js_msg_encoding.py, that still requires `make check`. That one is slower and is less of a footgun.) Furthermore, check_spidermonkey_style.py and check_macroassembler_style.py now use os.walk instead of consulting the repository [1]. This works better with untracked files and source packages and is also a bit faster. These scripts depend on the mozjs static library, so the build system runs them at some point after linking that. This means the scripts don't run when nothing changed or when you're still fixing compilation errors. The scripts should take less than a few seconds. If they're much slower please let me know - there are things we can optimize still. Finally, you can still run the scripts manually (`python config/check_spidermonkey_style.py` from the root directory). Jan [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1063728 [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1064316 _______________________________________________ dev-tech-js-engine-internals mailing list dev-tech-js-engine-internals@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
