Update: I landed some NSPR changes this week for stand-alone JS (shell)
builds:
- Only if you want to use CTypes (--enable-ctypes configure flag) or the JS
shell's --dll flag you'll need NSPR, so use one of --enable-nspr-build,
--with-system-nspr etc. Else don't pass any NSPR flags to configure and
you'll get a build that doesn't depend on NSPR.
- The --enable-posix-nspr-emulation configure flag and vm/PosixNSPR.* have
been removed.
This means Windows builds also no longer require NSPR.
Jan
On Tue, Jun 4, 2019 at 7:22 PM Jan de Mooij <jdemo...@mozilla.com> wrote:
> On Tue, Jun 4, 2019 at 5:48 PM Steve Fink <sf...@mozilla.com> wrote:
>
>> The library loading stuff is used for ctypes as well, which is used by
>> Firefox. It was the last difficult piece to remove.
>>
>
> True, but most shell and SpiderMonkey builds don't use --enable-ctypes so
> I think it would still be a win to drop NSPR support for typical shell and
> mozjs builds.
>
> Jan
>
>
>> On 6/4/19 1:34 AM, Jan de Mooij wrote:
>> > Oh I forgot about the PR_LoadLibraryWithFlags call in JS shell code. We
>> > should make that optional too...
>> >
>> > Jan
>> >
>> > On Tue, Jun 4, 2019 at 10:18 AM Jan de Mooij <jdemo...@mozilla.com>
>> wrote:
>> >
>> >> It's possible to build SpiderMonkey without depending on NSPR with
>> >> --enable-posix-nspr-emulation, this uses the implementation in
>> >> js/src/vm/PosixNSPR.{h,cpp} However these days we only depend on NSPR
>> for
>> >> memory mapped files in Wasm code (note that the PosixNSPR versions just
>> >> crash because this API, JS::DeserializeWasmModule, is only used in the
>> >> browser). We should either just remove the NSPR dependency completely
>> or
>> >> allow using PosixNSPR on all platforms.
>> >>
>> >> I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1556646 for this.
>> >>
>> >> Thanks,
>> >> Jan
>> >>
>> >> On Tue, Jun 4, 2019 at 12:52 AM Josh Matthews <j...@joshmatthews.net>
>> >> wrote:
>> >>
>> >>> If I remember correctly, there were at least attempts to remove NSPR
>> from
>> >>> the build on some platforms. Is that still possible on Windows in
>> >>> particular?
>> >>>
>> >>> Cheers,
>> >>> Josh
>> >>> _______________________________________________
>> >>> dev-tech-js-engine-internals mailing list
>> >>> dev-tech-js-engine-internals@lists.mozilla.org
>> >>> https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
>> >>>
>> > _______________________________________________
>> > dev-tech-js-engine-internals mailing list
>> > dev-tech-js-engine-internals@lists.mozilla.org
>> > https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
>>
>>
>>
_______________________________________________
dev-tech-js-engine-internals mailing list
dev-tech-js-engine-internals@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-js-engine-internals
