On Wed, Feb 3, 2010 at 18:39, Attila Szegedi <szege...@gmail.com> wrote:
> On 2010.02.03., at 17:52, Hannes Wallnoefer wrote:
>
>> The only
>> problem I had is the similarity between ModuleSource and ModuleScript
>> and related interfaces and classes. *ModuleSourceProvider and
>> *ModuleScriptProvder just look very similar, and it doesn't help that
>> both live in the same package. I know the naming makes sense, but
>> maybe it's possible to find terms that are farther apart. In Helma NG,
>> we use the terms Repository and Resource for module source
>> interfaces.
>
> Well, I'm open to that if better suggestions come up for my current terms 
> "module source" and "module script" - the former represents source code, the 
> latter represents a compiled object (actually holds an instance of 
> org.mozilla.javascript.Script). I attribute high significance to the 
> identifiers I use - code legibility is a very important aspect for me; I did 
> rename many of those classes several times before I dared to put the patch 
> out :-). I.e. "ModuleScript" used to be just "Module", but then I realized 
> that in this terminology, "module" is a JS object, an instance particular to 
> an execution of the program, hence the class I had there couldn't be named 
> "Module"... you can see how it goes.

ModuleSource and ModuleCompiled ?

Chris
_______________________________________________
dev-tech-js-engine-rhino mailing list
dev-tech-js-engine-rhino@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-tech-js-engine-rhino

Reply via email to