fantasai wrote:
1. Why do we call DeletingFrameSubtree before calling RemoveFrame? Why doesn't RemoveFrame take care of unmapping the content itself? (P.S. DeletingFrameSubtree is a really confusing name for something that doesn't delete the subtree.)
I think the answer to this is that we'd sort of like to switch to RemoveFrame just dealing. At least roc and I would.
2. Is there any reason we would call DeletingFrameSubtree or RemoveFrame on a continuation frame (rather than its first-in-flow) unless we were in the process of deleting its entire continuation chain?
I don't believe we ever do either of those. We should certainly only be calling DeletingFrameSubtree on primary frames (and asserting that if we're not already).
3. Is the primary frame for a piece of content ever not the first continuation?
No.
4. Would it be a bad idea for the frame to take care of unmapping itself and its children?
Imo, no.
5. Why does nsFrameManager::RemvoeFrame need aParentFrame? Are there cases where aParentFrame != aOldFrame->GetParent() ?
I'd have to check the callsites. I suspect no. -Boris _______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
