On 1/31/11 6:02 PM, Zack Weinberg wrote:
Indeed, it's just ParseSelectorString.

In that case the patch might be as simple as removing any OUTPUT_ERROR
calls from ParseSelectorString and its subroutines.

Hmm. Yeah, that would work; there are no subroutines to remove from, in fact.

matchesSelector is quickstubbed.

Ok, then can you suggest a *non*-quickstubbed API that throws
exceptions? I'm pretty sure it does do the same thing, but I looked for
the code that handles the conversion from nsresult to JS exception (in
general) and didn't find it.

Actually, the simplest thing if you have a tree is to remove this line:

  'nsIDOMNSElement.*'

from dom_quickstubs.qsconf and rebuild, then retest matchesSelector. Finding a non-quickstubbed method and then finding a way to make it fail is a bit of a pain...

At this point, I expect it behaves the same as a quickstubbed method, though.

-Boris
_______________________________________________
dev-tech-layout mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-layout

Reply via email to