LGTM...Let's ship it! https://bugzilla.mozilla.org/show_bug.cgi?id=547004
Thanks, Arnaud! --Jet ----- Original Message ----- From: "Daniel Holbert" <[email protected]> To: [email protected] Sent: Friday, October 25, 2013 7:19:07 PM Subject: Thoughts on toggling pref for the input type="color" form control, where it's supported? Hi layout folks, Thanks to the work of awesome contributor Arnaud Bienner, Nightly builds now have support for <input type="color">, on Windows, Mac, and Linux. (It renders as a button that spawns a colorpicker when you click it, and its 'value' attribute ends up being a hex representation of your chosen color.) It's currently preffed off by default, but we're considering preffing it on by default, in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=930277 The only reason that this pref-tweak isn't a no-brainer is that we can't actually pref it on *everywhere* yet -- only on the platforms where we have colorpicker-dialog backends implemented (which happen to be our P1 desktop platforms). We don't yet have colorpicker backends for Metro, B2G, or Android, in part because (as far as I can tell) no native color picker dialogs are available on those platforms. So, the current patch does *not* pref it on there (since it's non-functional there). Hopefully we'll have backends available on those other platforms soon (maybe with a HTML/CSS-based UI of some sort, if nothing better is available), though 2/3 are unassigned bugs at the moment. So: I initially was leaning towards conservatively waiting on the pref-tweak until we're ready to turn it on everywhere, but I've reconsidered, because: - I chatted with Brad Lassey, and he was OK with enabling it where it's ready (and he also quickly started a prototype Android backend. :)) - We apparently haven't held ourselves to the "must be ready on all platforms" standard for new form-controls in the past -- e.g. <input type="date"> & "time" are both enabled on Android/B2G but not on other platforms. - I chatted with dbaron, and he was ambivalent & suggested that I post here. So: I'm leaning towards r+'ing a "pref it on" patch, but I'm posting here to see if anyone had objections or comments. Thanks, ~Daniel _______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout _______________________________________________ dev-tech-layout mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-layout
