Gervase Markham wrote: > Edward Lee wrote: >> The channel acts just like before Link Fingerprints, except now >> /after/ the transfer has finished (meaning the download manager and >> dTa, which is getting data by chunks, have all the data that they >> normally would have gotten), the status code provided by OnStopRequest >> will report a failure code if the Link Fingerprint failed. >> >> The only exception that there's an early failure if the Link >> Fingerprint is invalid. We cancel the connection early because >> ideally, the channel consumer is going to notice the Link Fingerprint >> failure and report failure, so this prevents wasting the end user's >> bandwidth (which could cost a lot of money in some places). > > That makes sense to me.
But does that channel implementation seem reasonable? Nils? It's still up to the channel users to decide if they want to handle a failure status OnStopRequest. dTa can do what it'll do for the next version and ignore the status code and go on its happy way with the data it received. It seems that for the default download manager, which will be used by the average user, deleting the failed download is the right action. For those who are more advanced and use dTa, a dialog asking to retry, ignore, delete would be more appropriate. Ed _______________________________________________ dev-tech-network mailing list [email protected] https://lists.mozilla.org/listinfo/dev-tech-network
