There were some points peterv raised in his r-'ing a patch for bug
319768 which I need some clarification on.
(1) >> > > + nsClassHashtable<nsStringHashKey, nsString>
mNamespaceURIMap;
> > + nsClassHashtable<nsStringHashKey, nsString> mPrefixMap;
>
> Shouldn't these be nsDataHashTable's?
I thought about that, but per
http://developer.mozilla.org/en/docs/XPCOM:Hashtables#Which_Hashtable_Should_I_Use.3F
it appeared they should be nsClassHashTables.
Then you should change
+ nsDataHashtable<nsStringHashKey, nsString> stepAttrsMap;
Please check with bsmedberg.
Should I use nsClassHashtable or nsDataHashtable?
(2) Is there a better way to do this:
+
+ if (total > 1)
+ {
+ currentStep.Append('[');
+ currentStep.AppendInt(index);
+ currentStep.Append(']');
+ }
(3) peterv made a reference to:
aResult.AppendLiteral("\", '\"', \"");
This isn't documented in the XPCOM:Strings guide. Any pointers where I
can find documentation on it, and learn how to use it properly?
_______________________________________________
dev-tech-xpcom mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-tech-xpcom
