----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6861/#review10917 -----------------------------------------------------------
/trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java <https://reviews.apache.org/r/6861/#comment23449> In some cases, the loss of this check, may result in some typos in the authorization to pass through, instead of failing early. I don't see that this is too big of a problem, though. All characters are now valid in authorization tokens. /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java <https://reviews.apache.org/r/6861/#comment23450> I strongly recommend using the double-quote, if you're going to allow quoting. As demonstrated in this comment alone, the single quote has multiple purposes. You'll probably get less conflict if you rely on double-quote as the quote character. - Christopher Tubbs On Aug. 30, 2012, 8:59 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6861/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2012, 8:59 p.m.) > > > Review request for accumulo. > > > Description > ------- > > A patch for adding quoting to column visibility > > > Diffs > ----- > > > /trunk/core/src/main/java/org/apache/accumulo/core/security/Authorizations.java > 1379035 > > /trunk/core/src/main/java/org/apache/accumulo/core/security/ColumnVisibility.java > 1379035 > > /trunk/core/src/main/java/org/apache/accumulo/core/security/VisibilityEvaluator.java > 1379035 > > /trunk/core/src/test/java/org/apache/accumulo/core/security/ColumnVisibilityTest.java > 1379035 > > /trunk/core/src/test/java/org/apache/accumulo/core/security/VisibilityEvaluatorTest.java > 1379035 > > Diff: https://reviews.apache.org/r/6861/diff/ > > > Testing > ------- > > > Thanks, > > kturner > >
