Judging from that code, p is never null so that second case is unnecessary.
Sent from my phone, so pardon the typos and brevity. On Sep 12, 2012 12:29 PM, "David Medinets" <[email protected]> wrote: > The if statement belows uses a single & instead of &&. Therefore it is > not using short-circut logic. This seems like a typo. Does anyone > object if I change the '&' to '&&'? > > String delim = ""; > shellState.getReader().printString("System permissions: "); > for (SystemPermission p : SystemPermission.values()) { > if > (shellState.getConnector().securityOperations().hasSystemPermission(user, > p) & p != null) { > shellState.getReader().printString(delim + "System." + p.name()); > delim = ", "; > } > } > shellState.getReader().printNewline(); >
