----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8039/#review13399 -----------------------------------------------------------
/trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java <https://reviews.apache.org/r/8039/#comment28732> seems confusing to accept a range of keys and then only use the row portion of the range... eithier use the entire key or compose PRange out of rows... /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java <https://reviews.apache.org/r/8039/#comment28733> numRead does not seem to be incremented... If numRead were incremented, I think its possible that (numRead == k) could be true when there is no more data... maybe do ret.setMore(batchScanner.hasNext()) /trunk/proxy/src/main/thrift/proxy.thrift <https://reviews.apache.org/r/8039/#comment28728> How does the user indicate that they would like the system to set the timestamp? /trunk/proxy/src/main/thrift/proxy.thrift <https://reviews.apache.org/r/8039/#comment28730> I would advocate adding the following and making mutation use these struct PCoumnUpdate { 1:binary cf, 2: binary cq, 3:binary cv, 4:i64 ts 5:bool useSystemTime 6:binary value } struct PColumnDelete { 1:binary cf, 2: binary cq, 3:binary cv, 4:i64 ts 5:bool useSystemTime } /trunk/proxy/src/main/thrift/proxy.thrift <https://reviews.apache.org/r/8039/#comment28731> need a method to create a normal scanner in addition to the method to create a batch scanner /trunk/proxy/src/main/thrift/proxy.thrift <https://reviews.apache.org/r/8039/#comment28729> should take a list of ranges - kturner On Nov. 13, 2012, 4:37 p.m., Chris McCubbin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8039/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2012, 4:37 p.m.) > > > Review request for accumulo. > > > Description > ------- > > Patch submitted by Chris McCubbin to add thrift proxy to Accumulo, second > version > > > Diffs > ----- > > /trunk/pom.xml 1408812 > /trunk/proxy/README PRE-CREATION > /trunk/proxy/examples/python/README PRE-CREATION > /trunk/proxy/examples/python/TestClient.py PRE-CREATION > /trunk/proxy/examples/python/data/__init__.py PRE-CREATION > /trunk/proxy/examples/python/data/constants.py PRE-CREATION > /trunk/proxy/examples/python/data/ttypes.py PRE-CREATION > /trunk/proxy/examples/python/proxy/AccumuloProxy-remote PRE-CREATION > /trunk/proxy/examples/python/proxy/AccumuloProxy.py PRE-CREATION > /trunk/proxy/examples/python/proxy/__init__.py PRE-CREATION > /trunk/proxy/examples/python/proxy/constants.py PRE-CREATION > /trunk/proxy/examples/python/proxy/ttypes.py PRE-CREATION > /trunk/proxy/examples/ruby/README PRE-CREATION > /trunk/proxy/examples/ruby/accumulo_proxy.rb PRE-CREATION > /trunk/proxy/examples/ruby/data_constants.rb PRE-CREATION > /trunk/proxy/examples/ruby/data_types.rb PRE-CREATION > /trunk/proxy/examples/ruby/proxy_constants.rb PRE-CREATION > /trunk/proxy/examples/ruby/proxy_types.rb PRE-CREATION > /trunk/proxy/examples/ruby/test_client.rb PRE-CREATION > /trunk/proxy/examples/ruby/thrift.rb PRE-CREATION > /trunk/proxy/pom.xml PRE-CREATION > /trunk/proxy/proxy.properties PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyHarness.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/TestProxyClient.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/Util.java PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloException.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloProxy.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/AccumuloSecurityException.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/IOException.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/KeyValueAndPeek.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/NoMoreEntriesException.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PKey.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PKeyValue.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PMutation.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PRange.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/PScanResult.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyIteratorSetting.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxySystemPermission.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/ProxyTablePermission.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableExistsException.java > PRE-CREATION > > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/TableNotFoundException.java > PRE-CREATION > /trunk/proxy/src/main/java/org/apache/accumulo/proxy/api/UserPass.java > PRE-CREATION > /trunk/proxy/src/main/thrift/proxy.thrift PRE-CREATION > > /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyInstanceOperations.java > PRE-CREATION > /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyReadWrite.java > PRE-CREATION > > /trunk/proxy/src/test/java/org/apache/accumulo/TestProxySecurityOperations.java > PRE-CREATION > > /trunk/proxy/src/test/java/org/apache/accumulo/TestProxyTableOperations.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/8039/diff/ > > > Testing > ------- > > > Thanks, > > Chris McCubbin > >
