----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/#review15344 -----------------------------------------------------------
Hi Philip, thank you very much for incorporating my suggestions. I believe that your patch is on the way to get in. Couple of notes: 1) I've noticed that new files are introducing some trailing white space characters, would you mind removing them? I've highlighted them for you in the review notes below. 2) I don't thing that we need installed Accumulo in order to perform basic functional tests. I'm expecting that Accumulo have something like HBase/Hadoop MiniCluster to make functional tests easier, so I would recommend to use that. ivy.xml <https://reviews.apache.org/r/8559/#comment33005> Nit: Please remove the whitespace characters at the end. src/docs/user/accumulo-args.txt <https://reviews.apache.org/r/8559/#comment33010> Nit: Please remove the whitespace characters at the end. src/docs/user/accumulo-args.txt <https://reviews.apache.org/r/8559/#comment33011> Nit: Please remove the whitespace characters at the end. src/docs/user/accumulo.txt <https://reviews.apache.org/r/8559/#comment33006> Nit: Please remove the whitespace characters at the end. src/docs/user/accumulo.txt <https://reviews.apache.org/r/8559/#comment33007> Nit: Please remove the whitespace characters at the end. src/docs/user/accumulo.txt <https://reviews.apache.org/r/8559/#comment33008> Nit: Please remove the whitespace characters at the end. src/docs/user/accumulo.txt <https://reviews.apache.org/r/8559/#comment33009> Nit: Please remove the whitespace characters at the end. Thank you for all your hard work! Jarcec - Jarek Cecho On Jan. 10, 2013, 10:24 p.m., Philip Grim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8559/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2013, 10:24 p.m.) > > > Review request for accumulo, Sqoop and Jarek Cecho. > > > Description > ------- > > Adds the ability to import to an Accumulo table in much the same manner as > the current HBase import capability. Reported in JIRA as ACCUMULO-141 and > SQOOP-767. > > > Diffs > ----- > > ivy.xml ca2b89b > src/docs/user/accumulo-args.txt PRE-CREATION > src/docs/user/accumulo.txt PRE-CREATION > src/java/org/apache/sqoop/SqoopOptions.java 92c9996 > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java > PRE-CREATION > src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java > PRE-CREATION > src/java/org/apache/sqoop/manager/SqlManager.java ea961cd > src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 0c9cda6 > src/java/org/apache/sqoop/tool/ImportTool.java 415b315 > src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION > > Diff: https://reviews.apache.org/r/8559/diff/ > > > Testing > ------- > > > Thanks, > > Philip Grim > >
