Technically, you can. However, this is considered very bad practice, as the next person to touch these is likely going to overwrite your changes and then we'll have a mess of conflicts to deal with.
On Mon, Jul 22, 2013 at 11:14 PM, Supun Kamburugamuva <[email protected]>wrote: > Just out of curiosity, without copying the generated files can't we extend > from them and implement the required functionalities? > > > On Mon, Jul 22, 2013 at 5:02 PM, Corey Nolet <[email protected]> wrote: > > > bq. do we have to copy the generated file in to source code and commit? > > > > I believe the script that generates the thrift files also diffs them > > against the working tree and copies any changes where they go. At that > > point, you should just be able to stage them for a commit. > > > > > > > > On Mon, Jul 22, 2013 at 7:38 PM, Josh Elser <[email protected]> > wrote: > > > > > AFAIK, that's correct. Change the thrift definition and commit the new > > > generated file. > > > > > > > > > On 07/22/2013 07:27 PM, Supun Kamburugamuva wrote: > > > > > >> Hi all, > > >> > > >> I have a question about the thrift file generation. I can see you are > > >> generating the java classes from the thrift files. If we change a > thrift > > >> file do we have to copy the generated file in to source code and > commit? > > >> I'm bit confused about the work-flow. > > >> > > >> Thanks, > > >> Supun.. > > >> > > >> > > > > > > -- > Supun Kamburugamuva > Member, Apache Software Foundation; http://www.apache.org > E-mail: [email protected]; Mobile: +1 812 369 6762 > Blog: http://supunk.blogspot.com >
