The build.sh script executes the wrong plugin. I never bothered to fix it in 1.4 when I made the improvements for 1.5.
"mvn rat:check" (in 1.4's build.sh script) is actually equivalent to "mvn org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check" However, it should be: "mvn org.apache.rat:apache-rat-plugin:0.9:check" The rat plugin also may behave differently if executed within the build, vs. outside of it, and so might require different relative paths to exclude. See the 1.5.1-SNAPSHOT or master branch for a good example of a working rat plugin configuration that executes per-module. You may be able to get away with just executing "mvn org.apache.rat:apache-rat-plugin:0.9:check" in the build.sh script, though, instead of "mvn rat:check". -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Sun, Aug 11, 2013 at 4:06 PM, Mike Drob <[email protected]> wrote: > Figured out how to make git archive behave better, that will be fixed in > rc2. > > I created a transient branch to fix the version numbers. (1.4.4-release) > > However, when I attempt to build via src/assemble/build.sh, I get an > unexpected number of license errors building on Ubuntu 13.04, getting 55 > not 53. I looked at the actual results of the rat check and nothing seemed > out of place. Does anybody know if additional examples or files were added > between 1.4.3 and 1.4.4? > > > On Sat, Aug 10, 2013 at 11:11 AM, Keith Turner <[email protected]> wrote: > >> I think find + sed was used before 1.5 to do the search and replace of >> version numbers. >> >> Could create a transient branch in git. Do the search and replace there and >> tag from there. >> >> >> On Fri, Aug 9, 2013 at 9:40 PM, Josh Elser <[email protected]> wrote: >> >> > Actually, a few places (I think Christopher cleaned this up into one >> place >> > in 1.5?) >> > >> > ./src/server/src/main/c++/**mlock/Makefile: javah -classpath >> > ../../../../../../lib/**accumulo-server-1.4.4-**SNAPSHOT.jar >> > org.apache.accumulo.server.**tabletserver.$(LIB) >> > ./src/server/src/main/c++/**nativeMap/Makefile: javah -classpath >> > ../../../../../../lib/**accumulo-server-1.4.4-**SNAPSHOT.jar >> > org.apache.accumulo.server.**tabletserver.NativeMap >> > ./src/server/src/main/**resources/config.html: - version: >> > 1.4.4-SNAPSHOT >> > ./src/server/target/classes/**config.html: - version: 1.4.4-SNAPSHOT >> > ./src/core/src/main/java/org/**apache/accumulo/core/**Constants.java: >> > public static final String VERSION = "1.4.4-SNAPSHOT"; >> > ./src/examples/wikisearch/**ingest/bin/ingest_parallel.sh:** >> > JAR=$SCRIPT_DIR/../lib/**wikisearch-ingest-1.4.4-**SNAPSHOT.jar >> > ./src/examples/wikisearch/**ingest/bin/ingest.sh:JAR=$** >> > SCRIPT_DIR/../lib/wikisearch-**ingest-1.4.4-SNAPSHOT.jar >> > ./README:tar xvzf accumulo-1.4.4-SNAPSHOT-dist.**tar.gz). >> > ./README:Accumulo 1.4.4-SNAPSHOT has been tested with hadoop version >> > 0.20.2. >> > ./README: - version: 1.4.4-SNAPSHOT >> > ./README: - version: 1.4.4-SNAPSHOT >> > ./bin/config.sh: ACCUMULO_VERSION=1.4.4-**SNAPSHOT >> > ./docs/combiners.html:- version: 1.4.4-SNAPSHOT >> > ./docs/config.html: - version: 1.4.4-SNAPSHOT >> > >> > >> > >> > On 08/09/2013 09:33 PM, Josh Elser wrote: >> > >> >> Looks like bin/config.sh uses 1.4.4-SNAPSHOT and not 1.4.4 when setting >> >> ACCUMULO_VERSION. >> >> >> >> On 08/07/2013 05:50 PM, Mike Drob wrote: >> >> >> >>> Devs, >> >>> >> >>> I've made an initial attempt at building a 1.4.4-rc1 release. The src >> >>> tar, >> >>> signature, and md5sum are available at https://people.apache.org/~** >> >>> mdrob/ <https://people.apache.org/~mdrob/> >> >>> >> >>> The tar was generated from the 1.4.4rc1 tag by running "git archive -o >> >>> accumulo-1.4.4-rc1-src.tar.gz 1.4.4rc1" >> >>> >> >>> There is no vote yet because my keys are currently worthless for the >> >>> apache >> >>> web of trust. but if others can take a look at the artifact and provide >> >>> feedback, then we can get the ball rolling on a release. >> >>> >> >>> Thanks, >> >>> Mike >> >>> >> >>> >> >> >> > >>
