> On Oct. 28, 2013, 2:46 p.m., Bill Havanki wrote: > > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java, > > line 255 > > <https://reviews.apache.org/r/14995/diff/1/?file=372231#file372231line255> > > > > How about defining a new attribute "bcfile.fs.output.buffer.size" which > > can be primarily used, with "tfile" as a fallback for compatibility? (Ditto > > for the input buffer.) Leaving the tfile ones there will just be confusing > > after a while. > > John Vines wrote: > I wanted to avoid renaming the configuration parameters due to backwards > compatibility.
Absolutely, but my thinking was to look for "bcfile" first, and if it isn't there, then "tfile", and if that's not defined either, the default. That would start down the path of eventually deprecating and removing the tfile variations. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14995/#review27625 ----------------------------------------------------------- On Oct. 28, 2013, 6:09 p.m., John Vines wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14995/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 6:09 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-1679 > https://issues.apache.org/jira/browse/ACCUMULO-1679 > > > Repository: accumulo > > > Description > ------- > > Dirt simple fix which moves the 2 static variables and methods into BCFile. > I'm pretty sure we can't go about renaming those constants, but I could be > mistaken. General trivialness of this fix is why I'm review boarding it - it > seems too easy. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java > 2d9f6af > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Chunk.java > a075d87 > > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java > e89bb40 > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFile.java > f2cb326 > > core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/TFileDumper.java > d5b0a1b > > Diff: https://reviews.apache.org/r/14995/diff/ > > > Testing > ------- > > > Thanks, > > John Vines > >
